Skip to content

Add a debug version of python#596

Closed
nikhilweee wants to merge 664 commits intoconda-forge:python-debugfrom
nikhilweee:python-debug
Closed

Add a debug version of python#596
nikhilweee wants to merge 664 commits intoconda-forge:python-debugfrom
nikhilweee:python-debug

Conversation

@nikhilweee
Copy link
Contributor

@nikhilweee nikhilweee commented Nov 11, 2022 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Background

There have been multiple conversations around supporting a debug build of python both in this repository (#73) and elsewhere (conda-forge/staged-recipes#4812). There have also been previous attempts at this (#86) but there hasn't been any progress in the last 6 years. This PR is an attempt to revive those efforts.

Details

I am fairly new to writing recipes for conda-forge. In fact, I have never written recipes before, so please be humble with all the help you can. What I propose is to have another output, python-debug, which passes the env vars PY_INTERP_DEBUG=yes and DEBUG_PY=yes. The build script build_base.sh is already equipped to handle these env vars and pass on --with-pydebug to the build process.

Benefits

  • With this PR, users should be able to conda install python-debug to use a debug version of python.

Concerns

  • Adding an additional output requires more CI resources, something that we might want to conserve.
  • Adding another output makes meta.yaml even more messier.

Any feedback is much appreciated.

isuruf and others added 30 commits October 7, 2020 09:17
@isuruf
get rid of hand edited sysconfigdata
db61f52
@isuruf
Use non python tzdata
d2b586b
@isuruf
Fix SGI_ABI
52e9d6a
@isuruf
fix typo
f988bc8
@isuruf
Fix TZPATH on windows
baa1862
@isuruf
Revert "Skip stripping on osx arm64"
bd99141 
This reverts commit b2cb64a.
@isuruf
replace - with _
2faf5e0
@isuruf
need CPPFLAGS with -I. -isystem is not enough
362e1bc
@isuruf
Merge pull request #395 from ocefpaf/py39
e7ea437 
Py39
@isuruf
bump build number because prerelease one had the same the build number
3d22fab
@github-actions
bump build number because prerelease one had the same the build number
0a2bee1 
automerged PR by conda-forge/automerge-action
@mariusvniekerk
Add jinja2 variable for build_number
7c450dc
@github-actions
Actually bump build number
6542d7d 
automerged PR by conda-forge/automerge-action
@isuruf
Remove sysroot properly in sysconfigdata for osx
e2e8616
@isuruf
commit the change
c343c42
@github-actions
Remove sysroot properly in sysconfigdata for osx
4eef7d2 
automerged PR by conda-forge/automerge-action
@isuruf
Fix the rebase of a patch
7d61484
@github-actions
Fix the rebase of a patch
42ad321 
automerged PR by conda-forge/automerge-action
@mbargull
Make version in cbc.yaml, build_base.* consistent
2e6df79
@mbargull
Add patch for https://bugs.python.org/issue42015
ae86d01
@mbargull
Bump build number
c953720
@mbargull
Add mbargull to maintainers
f776b9f
@mbargull
Add python_impl+numpy to cbc.yaml for rerender
f2cc154
@mbargull
MNT: Re-rendered with conda-build 3.20.3, conda-smithy 3.8.2, and con…
7548664 
…da-forge-pinning 2020.10.13.19.09.25
@mbargull
Revert "Add python_impl+numpy to cbc.yaml for rerender"
c54fc58 
This reverts commit f2cc154.
@mbargull
Fix typo in build_base.bat
5bf1300
@mbargull
build_base.bat: Move comments out of for-block
20c4a58
@mbargull
Use consistent naming of non-dotted version
c79e58b
@mbargull
Fix another typo in build_base.bat
8d48a5e
@mbargull
maintainers: insert into alphabetical order
c5af9fa
isuruf and others added 18 commits August 23, 2022 15:53
@isuruf
fix python jinja var
52ee12c
MNT: Re-rendered with conda-build 3.22.0, conda-smithy 3.21.1, and co…
512b216 
…nda-forge-pinning 2022.08.23.13.46.03
@isuruf
Set --with-build-python
4f4c64f
@isuruf
3.10 -> 3.11
40a581d
@isuruf
Move Conda DLL patch to pylifecycle.c
8900866
@isuruf
3.10 -> 3.11
ca0181e
@isuruf
Fix typo
21f4471
@isuruf
pynche was removed
071818b
@chrisburr
Update to 3.11.0rc2
aad24dd
@chrisburr
Disable downstreams tests due to automatic skiping not working
0805b1a
@isuruf
update to 3.11.0
8d4b02e
@chrisburr
Merge pull request #577 from isuruf/3.11.0rc1
ef72f59 
3.11.0
@conda-forge-admin
[ci skip] added user chrisburr
f956d1d
@ocefpaf
Merge pull request #591 from conda-forge-linter/conda_forge_admin_590
e1ea111 
[ci skip] adding user @chrisburr
@conda-forge-curator
[ci skip] [skip ci] [cf admin skip] ***NO_CI*** admin migration Conda…
018b465 
…ForgeAutomergeUpdate
@nikhilweee
Merge branch 'main' into python-debug
84bf44f
@nikhilweee
Added separate output for python-debug
9d75734
@nikhilweee
Increased build number to 1
94403ac
@conda-forge-linter
Copy link

conda-forge-linter commented Nov 11, 2022

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@nikhilweee nikhilweee changed the title Python debug Also ship a debug version of python Nov 11, 2022
@nikhilweee nikhilweee changed the title Also ship a debug version of python Add a debug version of python Nov 11, 2022
@nikhilweee
Copy link
Contributor Author

nikhilweee commented Nov 11, 2022

@conda-forge-admin, please rerender

@nikhilweee nikhilweee closed this by deleting the head repository Nov 13, 2022
@nikhilweee
Copy link
Contributor Author

nikhilweee commented Nov 13, 2022 •
edited
Loading

I had initially thought of adding another output. But this had issues because conda doesn't create a separate build folder for each output (or maybe there is a way, I don't know yet). Now the approach is to have a separate output python-debug which only builds the debug version. Continuing in #597

@nikhilweee nikhilweee mentioned this pull request Nov 14, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.